Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI job for Flutter Android App #158

Merged
merged 28 commits into from
Dec 8, 2021
Merged

Add CI job for Flutter Android App #158

merged 28 commits into from
Dec 8, 2021

Conversation

d-uzlov
Copy link
Contributor

@d-uzlov d-uzlov commented Dec 7, 2021

Closes #110

d-uzlov added 20 commits November 29, 2021 10:41
@d-uzlov
add dockerfile for flutter android app
cb91d09 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
add commands to build flutter android app
65ac9fd 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
add command to build flutter test for android
68ecbaa 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
add flutter-android cloudbuild
1251c4d 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
add bazel remote cache support to flutter makefile
d0b43a2 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix test apk target
45d28c6 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
adjust artifact output location
15c5753 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix python dependency in dockerfile
42fba19 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
use separate ndk layer in dockerfile
494a58b 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix android/test_apk make target
4e24daf 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix docker flutter android apk make target
7fe7376 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix result dir check in instrumented test
e939632 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
refactor flutter android dockerfile
b05e345 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix test apks
5a8263c 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
switch to e2 8core build machines
998c601 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
refactor cloudbuild files
e2c7a5f 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
remove docker buildkit
989e121 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix typo
417eb86
@d-uzlov
fix release apk upload
91c02cf 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
add comments
fa02d60 
Signed-off-by: Danil Uzlov <[email protected]>
@github-actions
Copy link

github-actions bot commented Dec 7, 2021 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@d-uzlov
fix envs in dockerfile
1525b3a 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
add proper docker image build command
4229b73 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
adjust gitignore
b55ab18 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix formatting
cf6998b 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov d-uzlov force-pushed the 110/flutter-android-ci branch from ea8a511 to cf6998b Compare December 7, 2021 09:07
@d-uzlov
fix linter
b83441f 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
add ANDROID_NDK_HOME to dockerfile
77e7474 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix image tag in docker/android/apk command
62122e6 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov
fix typo
7bdd285 
Signed-off-by: Danil Uzlov <[email protected]>
@d-uzlov d-uzlov force-pushed the 110/flutter-android-ci branch from e26fbf3 to 7bdd285 Compare December 7, 2021 09:54
@d-uzlov d-uzlov marked this pull request as ready for review December 7, 2021 10:12
@d-uzlov d-uzlov requested a review from anhappdev December 7, 2021 10:14
@d-uzlov
Copy link
Contributor Author

d-uzlov commented Dec 7, 2021 •
edited
Loading

@anhappdev I disabled docker buildkit for Flutter CI because for some reason it often partially rebuilds the image even when nothing changed in the dockerfile and in docker build context.
You can go to the list of avaiable tags for mlperf-mobile-android image in Google Console and see that most of the images don't have any tags. This happened because dockerfile with the same git hash was rebuilt several times, and the tag containing this hash moved to the newly built image.
Do you know anything about this and how to fix it?

@anhappdev
Copy link
Collaborator

Which docker version is used by the CI?
It seems to be a bug with docker:
moby/buildkit#1981
There is a comment that he still have the issue with the newer version, though it should be fixed.

@d-uzlov
Copy link
Contributor Author

d-uzlov commented Dec 8, 2021

Version of docker in CGP is 19.03.9, so we probably see this bug you linked.

d-uzlov
d-uzlov commented Dec 8, 2021
View reviewed changes
flutter/Makefile
docker/android/apk: android/docker/image
@# if the build fails with java.io.IOException: Input/output error
@# remove file android/gradle/wrapper/gradle-wrapper.jar
MSYS2_ARG_CONV_EXCL="*" docker run --rm -it --user `id -u`:`id -g` -v $(CURDIR)/..:/mnt/project mlcommons/mlperf_mobile_flutter bash -c "cd /mnt/project/flutter && make prepare-flutter && make android/apk"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command doesn't utilize bazel cache.
I consider this command a proof that the docker container works both on CI and locally, and not a command that people should actually use to build the app.
A plan to add cache support while refactoring makefiles for #112.

anhappdev
anhappdev requested changes Dec 8, 2021
View reviewed changes
flutter/Makefile Show resolved Hide resolved
flutter/Makefile Show resolved Hide resolved
@d-uzlov d-uzlov merged commit 06001d9 into master Dec 8, 2021
@d-uzlov d-uzlov deleted the 110/flutter-android-ci branch December 8, 2021 08:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anhappdev anhappdev anhappdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure Cloud Build CI for Android Flutter app
2 participants
@d-uzlov @anhappdev